Repository navigation
Add update-manager command for proxy agent scripts - #17
Open
fivetran-paulharper wants to merge 1 commit into
Open
fivetran-paulharper wants to merge 1 commit into
fivetran-paulharper wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change enabling manager updates independently of the agent container.
No open issues 🎉
What changed in this PR
Adds update-manager to the Bash and PowerShell management scripts so users can update the manager independently of the agent container, without restarting it or requiring valid agent configuration.
Changes:
- Downloads and validates a replacement script before replacing the installed manager, with temporary-file cleanup.
- Adds tests for successful updates, URL overrides, proxy use, and failed or invalid downloads.
- Documents the new command and manual update steps for older installations.
| File | Description |
|---|---|
tests/pwsh/Manager.Tests.ps1 |
Adds PowerShell update tests and download stubbing. |
tests/bash/stubs/curl |
Supports output files and simulated download failures. |
tests/bash/manager.bats |
Tests Bash updates, configuration independence, and failure cleanup. |
README.md |
Documents manager updates and migration from older installations. |
proxy-agent-manager.sh |
Implements Bash self-update before agent configuration validation. |
proxy-agent-manager.ps1 |
Implements PowerShell self-update with proxy support and syntax validation. |
Review effort: Balanced
fivetran-paulharper
marked this pull request as ready for review
November 6, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.