Skip to content

zig: a lifted view keeps its drag through dvui's captureMouseGet #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foxnne merged 1 commit into from
Oct 17, 2026
Merged

zig: a lifted view keeps its drag through dvui's captureMouseGet #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/layout/Chooser.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ fn carryLifted(self: *Chooser) void {
} else {
f.beginViewDrag(lift.id, lift.rect);
// From the motion that lifted it on: a release in the same frame is the drag's too.
if (dvui.currentWindow().captures[0]) |cm| // ZIG017: per-pointer capture (dvui#1014); 0 is the mouse
if (dvui.captureMouseGet()) |cm|
dvui.captureMouseCustom(cm, lift.event);
}
self.carried = lift.id;
Expand Down
2 changes: 1 addition & 1 deletion plugins/workbench/src/Workspace.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ fn lift(id: []const u8, from: dvui.Rect.Physical, event_num: u16) void {
wb.carried_tab_key = std.hash.Wyhash.hash(0, id);
runtime.host().beginViewDrag(id, from);
if (runtime.host().viewDragSurface() == null) return;
if (dvui.currentWindow().captures[0]) |cm| // ZIG017: per-pointer capture (dvui#1014); 0 is the mouse
if (dvui.captureMouseGet()) |cm|
dvui.captureMouseCustom(cm, event_num);
}

Expand Down
Loading