Skip to content

tests: the openapi test registers a command again as #536 now does it - #557

Closed
foxnne wants to merge 1 commit into
mainfrom
tests/openapi-command-again
Closed

foxnne wants to merge 1 commit into
mainfrom
tests/openapi-command-again

Conversation

@foxnne

@foxnne foxnne commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

What changes

main's integration tests fail (e.g. on #553): control: /openapi.json describes each command's body and the declared events expects "Off" and finds "Off again".

#508's test registers t.off twice from the same plugin and expected the first to stand ("the server runs the first"). #536, which merged just before it, made the same plugin registering its own id again put the new one in the first's place, as a reload of its registrations does (Host.registerCommand). Each PR passed on its own. The test now expects the second registration's summary, and its comment says why. The description still has one path for the id, which is what the test is about.

SDK impact

  • None
  • Core-only or additive: reaches plugins at the next SDK release
  • Fingerprint moved: recorded in sdk/src/version.zig, sdk_version untouched, PR labelled sdk
  • SDK release: bumps sdk_version, lists the sdk PRs since the last sdk-v* tag

Verified

  • macOS: zig build test-integration, 54/54 steps, 595/595 tests; scripts/check-fmt.sh passes.
  • Windows:
  • Linux: CI
  • Web:

Follow-ups

None.

🤖 Generated with Claude Code

#508's test expected a second registration of `t.off` by the same plugin to
be ignored. Since #536 that puts the new one in the first's place (a reload),
so `main`'s integration tests failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@foxnne
foxnne enabled auto-merge (squash) October 18, 2026 16:11
@foxnne

foxnne commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded: main fixed this test another way (the second t.off now comes from a different plugin, so the first stands), and this branch now conflicts with it.

@foxnne foxnne closed this Oct 18, 2026
auto-merge was automatically disabled October 18, 2026 18:01

Pull request was closed

@foxnne
foxnne deleted the tests/openapi-command-again branch October 18, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant