Skip to content

sdk: a plugin build compiles its install helper once, in Debug #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
foxnne merged 1 commit into from
Oct 18, 2026
Merged

sdk: a plugin build compiles its install helper once, in Debug #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 20 additions & 10 deletions sdk/plugin_sdk.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,19 +272,29 @@ pub fn installBeside(b: *std.Build, artifact: *std.Build.Step.Compile, opts: Ins
addDevInstall(b, artifact, opts.plugin, artifact.out_filename, b.fmt("install '{s}' beside plugin '{s}'", .{ artifact.out_filename, opts.plugin }));
}

/// The helper `addDevInstall` runs, one per builder however many artifacts it installs. Debug:
/// it only copies a file, and a ReleaseFast compile of it cost a cold plugin build about 4 s.
fn devInstallExe(b: *std.Build) *std.Build.Step.Compile {
const gop = dev_install_exes.getOrPut(b.allocator, b) catch @panic("OOM");
if (!gop.found_existing) {
const fizzy_dep = fizzyDep(b, .{ .target = b.graph.host, .optimize = .fast });
gop.value_ptr.* = b.addExecutable(.{
.name = "fizzy-plugin-dev-install",
.root_module = b.createModule(.{
.root_source_file = fizzy_dep.path("plugin_sdk_install.zig"),
.target = b.graph.host,
.optimize = .debug,
}),
});
}
return gop.value_ptr.*;
}
var dev_install_exes: std.AutoHashMapUnmanaged(*std.Build, *std.Build.Step.Compile) = .empty;

/// Copy `artifact` to `{plugins}/{dir_name}/{file_name}` on every `zig build install`, through
/// `plugin_sdk_install.zig`: Zig 0.17's build has no custom steps.
fn addDevInstall(b: *std.Build, artifact: *std.Build.Step.Compile, dir_name: []const u8, file_name: []const u8, step_name: []const u8) void {
const fizzy_dep = fizzyDep(b, .{ .target = b.graph.host, .optimize = .fast });
const dev_exe = b.addExecutable(.{
.name = "fizzy-plugin-dev-install",
.root_module = b.createModule(.{
.root_source_file = fizzy_dep.path("plugin_sdk_install.zig"),
.target = b.graph.host,
.optimize = .fast,
}),
});
const dev = b.addRunArtifact(dev_exe);
const dev = b.addRunArtifact(devInstallExe(b));
dev.setName(step_name);
dev.addArtifactArg(artifact);
dev.addArgs(&.{ dir_name, file_name });
Expand Down
Loading