Repository navigation
macos: a window's glass bevel follows a live resize - #576
Merged
Merged
Conversation
The frost and colour of a window of Liquid Glass are masked by the clearing bevel, a mask layer sized by each frame's look. A live resize grows the parts at once, while the mask stayed at its old size until the next frame. The mask is anchored at the bottom, so as the window grew, the frost along its top was masked out for a frame and the old mask's rounded corner showed as a diagonal, appearing and disappearing as the window was dragged. Each masked part now sizes its mask as AppKit resizes it, through one frame-changed observer, and unregisters when the glass is taken away.
foxnne
marked this pull request as ready for review
October 18, 2026 19:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the window material (fizzyedit/plans#27). Stacked on #549 (
app/glass-material), where #565 put fizzy's window glass on a plain dvui app's windows.The bug (the user, on
run-dvuiwith Liquid Glass): a blurred patch in the window's top-left corner, with a diagonal edge, that appears and disappears while the window is resized.Why: the frost and colour of a window of Liquid Glass are masked by the clearing bevel, a mask layer that each frame's look sizes (
windowFeatherMask). A live resize grows the parts straight away (autoresizing), but the mask stayed at its old size until the next frame. AppKit's layers are anchored at the bottom-left, so as the window grew, the frost along its top fell outside the old mask for that moment, and the old mask's rounded corner showed as a diagonal.The fix: each masked part (frost and colour) sizes its mask as AppKit resizes it. One shared observer listens for each part's frame changes (
FizzyGlassMaskFollower), andwindowGlassRemoveunregisters a part as the glass is taken away. Fizzy's own windows install the same parts, so they get it too.SDK impact
Verified
scripts/check-fmt.sh,zig build.run-dvuiwindow on Liquid Glass (and a fizzy window): no patch in the corner.🤖 Generated with Claude Code