Repository navigation
check: fizzy-main checks out the backend glass core imports - #5
Merged
Merged
Conversation
Since fizzyedit/fizzy#586, core imports the backend's glass (backend/src/glass/, backend/src/glass_look.zig), and fizzy's scripts/pack-sdk.sh vendors both into the SDK tarball. The fizzy-main job's sparse checkout took only sdk and core, so every plugin's fizzy-main build failed on the missing files. It now checks out what the tarball carries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since fizzyedit/fizzy#586,
coreimports the backend's glass:backend/src/glass/andbackend/src/glass_look.zig. fizzy'sscripts/pack-sdk.shvendors both into the SDK tarball, so released SDKs are fine. Butcheck.yml'sfizzy-mainjob sparse-checks-out onlysdkandcore, so every plugin'sfizzy-mainbuild now fails:It shows up on fizzyedit/drive#13, chat#16 and example-plugin#13, whose real builds pass.
What changes
The sparse checkout takes what the tarball carries:
/sdk/,/core/,/backend/src/glass/and/backend/src/glass_look.zig. These are non-cone patterns, since one is a single file.sdk/core_module.zigon fizzymainreaches nothing else underbackend/.Releasing
Plugins call
check.yml@v7, so this reaches them whenv7is moved, or through av8.🤖 Generated with Claude Code