Repository navigation
Conversation
Claude-Session-Id: 01a15eea-9e79-7161-890a-03eac0c66cf1
Move live inspection, capabilities, Atlas SQL Server integration, and bundle migration engines from commons-db into sqlglot-go/database. Keep commons-db as typed compatibility shims and preserve SQL Server v1 artifact hashes and locking. Add one schema inspect and migrate plan/apply CLI, read-only script analysis, and reviewed PostgreSQL/SQLite schema artifacts with exact saved SQL, bounded locking, destructive acknowledgements, drift detection, rollback, and postconditions. Resolve HCL primary-key names, SQL literals, and effective collations before building SQL Server artifacts. Validation: all 10 tracked Gavel fixture gates pass, including standalone tests, build, native lint, SQLite example, PostgreSQL reviewed execution, commons-db compatibility, and remote SQL Server runtime and bundle execution. The general Gavel test adapter separately reports missing Ginkgo metadata; the command fixture runs successfully. Reviewed PostgreSQL script/security bundles and OIPA deployment integration remain tracked backlog work. This builds on the trigger and planner changes in sqlglot-go PR #9. Gavel-Issue-Id: e5e4b378-75e4-4291-9c72-585d138a7cef
Mirror the verified DefaultPlan compatibility export from sqlglot-go PR #10 into the original checkout. Ginkgo verifies planning and refusal to execute without a database connection.
Retain the verified PR #10 fix in the original checkout: convert native separators and keep drive letters in URI paths. Ginkgo covers drive URI encoding and exact filenames with spaces and URL punctuation.
…w order Row order from unordered queries was flagged as nondeterminism, causing false failures and undercounted coverage. Repeat checks now compare rows as multisets, and same-rows-different-order results count toward the comparable floor. Adds regression tests for the execution oracle, runs them in CI, and moves the nil check ahead of the field access in the Redshift UNPIVOT test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
commons-dbintosqlglot-go/database;commons-dbkeeps typed compatibility shims.schema inspectandmigrate plan/applyCLI.Why
commons-dbkept compatible.Notes