Repository navigation
fduty: pass timezone on automation create and update - #212
Merged
Merged
Conversation
Requires go-flashduty AutomationRuleUpdateRequest.Timezone from automation: accept timezone on rule update. go.mod stays on v0.15.10 until that commit is fetched.
The create and update commands set AutomationRuleUpdateRequest.Timezone. That field is on go-flashduty 7a88b4a, which is not in a release tag yet.
Point go-flashduty at 26910a1 so --timezone and the incident custom-field map both compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做了什么
fduty automation create和fduty automation update可以传--timezone。不传时，创建仍走成员、账号、Asia/Shanghai；更新保持原来的时区，包括老数据里的空串。更新时显式传空字符串，会写成 UTC，不会改回账号默认。fduty safari automation-rule-update的生成参数里也有--timezone。技能说明要求：用户点名了时区才传这个参数；更新之后读回schedule_next_fire_at_ms，不要假设原来排好的那一次还会跑。依赖 SDK：flashcatcloud/go-flashduty#91 （
AutomationRuleUpdateRequest.Timezone）。怎么验证
go test -count=1 ./internal/cli/ ./internal/skilldoc/ ./internal/cmd/skilldoc/ ./internal/cmd/cligen/