Repository navigation
docs(doc-review): daily review 2026-10-30 — AI SRE config repair and resume, RUM native NL query, multi-value incident filters - #1156
Open
flashduty[bot] wants to merge 1 commit into
Conversation
…resume, RUM native NL query, multi-value incident filters
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-10-30
Mode: diff (since
2026-10-29T08:17:22Z)Findings: 7 total — 0 high, 5 medium, 2 low (5 applied in this PR, 1 derivative applied in this PR, 1 cross-repo follow-up)
Changes
flashduty-website(cross-repo)No path changes: no
.mdxwas renamed or moved, nodocs.jsonnavigation touched (jq empty docs.jsonpasses), so no redirects are needed.Overlap with open PRs
zh|en/on-call/incident/search-view-incident.mdxonly in the 综合信息 / Issue 信息 row (~line 164) andzh|en/rum/analytics/chart-readings.mdx, plus the changelog's2026-10-29<Update>block. This PR's f005 hunk sits in the 标签 / 自定义字段 bullets (~line 67) and f006 prepends a separate2026-10-30<Update>block above the2026-10-25one — no textual overlap, no hunk conflict; whichever lands first, the other rebases cleanly.absent_counts_as_normalfor threshold recovery, monitors) — deliberately not re-filed: the monitors submodule change in this window (RecoverRow.tsx,ruleFormValues.ts,absent_counts_as_normalin the form) is exactly what docs(monitors): document counting absent alert objects as normal for threshold recovery #1147 documents and docs(api-reference): daily api-review 2026-10-29 — drop license release_limited, add rum cumulative, monit absent_counts_as_normal #1150 exposes in the OpenAPI specs.Review checklist
Cross-repo follow-ups (flashduty-website)
content/changelog/2026-10-19(110 files). Draft a dated.mdx+.zh.mdxpair for both features. Not applied here — docs repo only.No
derivative_surfaces.website_integrationsfollow-up: this window shipped no new or changed alert-source/tool integration, so the catalog and the "60+" counts are unaffected.Mapping warnings
cmd/engine/controller/notify/logic/onboarding/cmd/server/controller/onboarding/structs/ai_sre.gologic/resource/usage.gostructs/license.gocmd/server/controller/data/src/Packages/saas/pages/StatusPagestatuspagemapssrc/Packages/saas/pages/Dashboard; the console's Status Page pages live underpages/StatusPagesrc/Packages/saas/pages/OnboardingOncallsrc/Packages/saas/pages/Onboardingorigin/mainbyb914aedeb"retire legacy quick-start onboarding pages" — drop from mappingsrc/Packages/saas/pages/Guideorigin/mainby4d6a89327"下线旧版 /init-channel 强制引导" — drop from mappingderivative_surfaces.comparison_page→ `zhSkipped
absent_counts_as_normal(monit submoduleRecoverRow.tsx,ruleFormValues.ts,types.ts; monit-webapi 0 commits) — covered by open docs(monitors): document counting absent alert objects as normal for threshold recovery #1147 (docs) and docs(api-reference): daily api-review 2026-10-29 — drop license release_limited, add rum cumulative, monit absent_counts_as_normal #1150 (OpenAPI); not re-filed.structs/webhook.goIsIMApp(),notify/{fire,personal,mention}.go; saasChannel/imNotificationAccess.ts,用于告警分派需 On-Call 专业版) — already documented as a version-requirement Tip on all fivezh/on-call/integration/instant-messaging/*.mdxpages and inzh/ai-sre/{im,overview}.mdx, so no finding.logic/credential/service.goOnRejected,logic/tool/builtin/mcp.go) — no doc claim contradicts it;zh/ai-sre/mcp.mdxalready says tokens refresh near expiry and only an expired credential needs re-authorising.logic/notify.goCanSendIMNotify) — IM subscriptions only exist on internal status pages, which already require Professional (zh/on-call/statuspage/statuspage.mdx), so the gate cannot bite on a documented path; no finding.logic/license/license.go,logic/credits/*,docs/ai-sre-billing.md;src/pages/Wallet/Subscription/AiSre) — already documented inzh/ai-sre/overview.mdx§开通与计费.callee/pgy.go(billing RPC), fc-datasource/fc-pgy/terraform-provider/flashduty-cli/mcp-server/flashduty-runner/go-flashduty/flashduty-app/monit-webapi/monit-edge (0 mapped commits), fc-event PG/Mongo parity internals, monit onboarding datasource cards losing their one-line descriptions (pure layout).Validation
mint broken-links(Node v20.18.0, mint 4.2.1178):success no broken links found in the files that parsed. Exit code 1 is the 36 pre-existing parse failures, all underon-call/integration/alert-integration/alert-sources/*.mdx.comm -12), i.e. every changed file was really parsed and link-checked, not skipped.jq empty docs.json→ OK (navigation untouched, no new pages).