fix(tile_layer): Don't mark a failed tile ready to display without an error image - #2260
Open
nebkat wants to merge 1 commit into
Open
fix(tile_layer): Don't mark a failed tile ready to display without an error image#2260nebkat wants to merge 1 commit into
nebkat wants to merge 1 commit into
Conversation
… error image readyToDisplay documents itself as true when "loading errored but an error image is configured", but _display() set it on any error regardless. A tile that failed and has nothing to paint therefore counted as covering its area, so renderTiles discarded the coarser ancestor standing in for it and the area went blank instead of staying upscaled. Services whose coverage depth varies by location show this plainly: past the deepest level available at a given place the tiles 404, and zooming in lost detail that was already on screen. Set it from errorImage, as documented. Tiles that have an error image are unaffected, and must stay ready — opacity is gated on this, so the error image would otherwise never be painted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readyToDisplaydocuments itself astruewhen "loading errored but an error image is configured", but_display()set it on any error regardless. A tile that failed and has nothing to paint therefore counted as covering its area, sorenderTilesdiscarded the coarser ancestor standing in for it and the area went blank instead of staying upscaled. Services whose coverage depth varies by location show this plainly: past the deepest level available at a given place the tiles 404, and zooming in lost detail that was already on screen.Set it from
errorImage, as documented. Tiles that have an error image are unaffected, and must stay ready - opacity is gated on this, so the error image would otherwise never be painted.