docs: PR #191のレビュー知見を記録する - #194
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
Reviewed changes have no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
PR #191のレビュー知見を整理し、汎用的なテスト原則をチェックリストへ統合するドキュメント変更です。
Changes:
- テスト網羅性・結線テストの項目を追加
- 新たなレビュー知見3件を記録
- 既存の汎用知見2件をチェックリストへ移管
| File | Description |
|---|---|
.claude/skills/pj-checklist/SKILL.md |
テスト確認項目を追加 |
.claude/review-lessons.md |
新たな知見を記録し、統合済み項目を削除 |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
PR #191のレビュー指摘とCI失敗から得た再発防止パターンを
.claude/review-lessons.mdに記録する。記録が20件を超えるため、抽象ルールとして書ける既存の2件をpj-checklistへ統合した。変更内容
review-lessons.mdに3件を追加したgh pr viewは、PRが無いときも認証切れのときも同じく非ゼロで終了するため、not-foundのメッセージだけを「対象なし」として扱うpj-checklistのテスト節へ移し、review-lessons.mdから削除した。どちらもPR固有の内容を含まない抽象ルールになっていたためテスト計画
N/A
備考
review-lessons.mdは20件になり、/harness-auditを実行する目安（15件超）を超えている。Generated with Claude Code