Update spdlog submodule to v1.17.0 - #190
Merged
Merged
Conversation
The flingengine/spdlog fork's v1.x branch was already synced with upstream gabime/spdlog, but was missing the release tags after v1.3.1. Pushed the missing tags (v1.4.0-v1.17.0) to the fork and bumped the submodule pin to the latest stable release. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
spdlog v1.17.0 bundles fmt v12, which no longer implicitly formats arbitrary enums like VkResult. Cast to int in VK_CHECK_RESULT so the build keeps working with the upgraded submodule. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
fixes a bunch of annoying warnings about char's from spdlog |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flingengine/spdlogfork'sv1.xbranch was already synced with upstreamgabime/spdlog, but was missing the release tags afterv1.3.1. Pushed the missing tags (v1.4.0-v1.17.0) to the fork so it has proper release references.external/spdlogsubmodule pin fromv1.3.1tov1.17.0(latest stable upstream release).VK_CHECK_RESULTinGraphicsHelpers.hwas logging a rawVkResult, which no longer compiles. Fixed by casting tointat that call site — the only place in the codebase that logs aVkResultdirectly.Test plan
cmake . -B build -DCMAKE_BUILD_TYPE=Debug -DDEFINE_SHIPPING=OFF && cmake --build build -j$(nproc)— builds clean./build/FlingTests/bin/FlingTests— all tests pass (172 assertions, 17 test cases)🤖 Generated with Claude Code