Make historic variable cleanup dependent scope type aware - #4275
Merged
Merged
Conversation
Runtime cleanup honours the dependent scope types registered on an engine configuration, historic cleanup did not: such rows have no process instance id, and the CMMN historic delete pinned the scope type to 'cmmn', so they leaked along with their byte arrays. All dependent scope variables use the instance id as scope id, so the cleanup keys off that, which covers the whole BPMN execution tree in one statement. Adds a scope types aware find and (bulk) delete alongside the existing single scope type methods, used from DefaultHistoryManager, DefaultCmmnHistoryManager and CmmnHistoryHelper. Also fixes findHistoricalVariableInstancesBySubScopeIdAndScopeType, which passed a sub scope id to the scope id statement and matcher.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime cleanup honours the dependent scope types registered on an engine configuration, historic cleanup did not: such rows have no process instance id, and the CMMN historic delete pinned the scope type to 'cmmn', so they leaked along with their byte arrays. All dependent scope variables use the instance id as scope id, so the cleanup keys off that, which covers the whole BPMN execution tree in one statement.
Adds a scope types aware find and (bulk) delete alongside the existing single scope type methods, used from DefaultHistoryManager, DefaultCmmnHistoryManager and CmmnHistoryHelper.
Also fixes findHistoricalVariableInstancesBySubScopeIdAndScopeType, which passed a sub scope id to the scope id statement and matcher.