Repository navigation
fix(ci): bump go toolchain and dedupe govuln sarif stacks - #490
Merged
Merged
Conversation
The security job fails on upload since codeql-action 4.38.2, which rejects SARIF results with duplicate stacks. govulncheck emits exact duplicate call stacks for some findings, and on go1.26.8 it reports several reachable stdlib net/http vulns that do so. Bump the toolchain to go1.26.9, which fixes those vulns, and dedupe stacks before writing govuln.sarif so a future finding cannot break the upload again.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
securityjob has failed on every run since codeql-action was bumped to 4.38.2:upload-sarifnow rejects results whosestackscontain duplicate items, and govulncheck emits exact duplicate call stacks for some findings. On the pinned go1.26.8 toolchain, govulncheck reports several reachable stdlibnet/httpvulns (fixed in go1.26.9), and those are the findings with duplicate stacks.Notable Changes
toolchainto go1.26.9, which removes the reachable stdlib findings.scan securitydedupes each result's stacks withjqbefore writinggovuln.sarif, so a future finding with duplicate stacks can't fail the upload.No ticket