tests: runtime_shell: Add timeouts for runtime shell testing - #12386
tests: runtime_shell: Add timeouts for runtime shell testing#12386cosmo0920 wants to merge 1 commit into
Conversation
Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe runtime shell CTest entries now use a 90-second timeout for both Windows PowerShell and Unix shell test loops. ChangesRuntime shell test timeouts
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to Runtime shell tests now fail after 90 seconds rather than hanging indefinitely. Both platform registration loops are covered, with no remaining merge-readiness risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30ab4f9234
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set_tests_properties(${script} PROPERTIES | ||
| ENVIRONMENT "${RUNTIME_SHELL_ENVIRONMENT}" | ||
| LABELS "runtime_shell" | ||
| TIMEOUT 90 |
There was a problem hiding this comment.
On Linux, this blanket timeout also covers proxy_logs_expect.sh, which invokes go_plugins/build_test_plugins.sh; on a cold host that script may download and extract Go 1.25.4, verify CGO with a build, download modules, and build the plugin before running Fluent Bit. Per ctest --help-property TIMEOUT, the limit applies to the entire test process and kills it once exceeded, so a valid first run on a slower machine or network can now fail at 90 seconds. Assign this test a longer per-test timeout or move its provisioning outside the timed test.
Useful? React with 👍 / 👎.
1 participant
Added a 90-second CTest timeout to all Unix and Windows
runtime_shelltests in CMakeLists.txt.Verified:
ctest --test-dir build -R '^in_syslog_.*_expect\.sh$' --output-on-failure: all 5 passed.Integration/Valgrind runs were not applicable to this CMake-only timeout change.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit