Replace ecore_pipe to glib api in TizenEventLoop - #192
Conversation
609e79c to
64daebe
Compare
Replace Ecore pipes and per-task timers with a single GLib source that tracks the earliest Flutter task on the Tizen main context. Preserve delayed execution, posting order, worker-thread scheduling, re-entrant callbacks, and source cleanup. Remove the remaining Ecore dependency from display refresh reporting by using the existing 60 Hz constant.
64daebe to
a2b7f08
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
| } else { | ||
| display.refresh_rate = 1 / fps; | ||
| } | ||
| display.refresh_rate = 60.0; |
There was a problem hiding this comment.
The Linux embedder (fl_display_monitor.cc) gets the real per-monitor refresh_rate via gdk_monitor_get_refresh_rate() and updates it on hotplug. GDK isn't available on Tizen, but the same value is obtainable by directly parsing the refresh field from the wl_output.mode event - no Ecore needed. Could you at least file a follow-up issue for the hardcoded 60.0 instead of leaving it silent?
There was a problem hiding this comment.
ecore_animator_frametime_get() returns the default value of 1 / 60.0f unless otherwise set. Therefore, apply 60.0 to match existing behavior.
There was a problem hiding this comment.
You're right that ecore_animator_frametime_get() defaults to 60, but it doesn't actually reflect the real monitor's frame rate, so this will need to be fixed eventually. Even if not right now, could we at least leave a follow-up issue for it?
There was a problem hiding this comment.
um... #193 I have made an issue. However, I am not sure if we will be able to resolve it.
2 participants
Replace Ecore pipes and per-task timers with a single GLib source that tracks the earliest Flutter task on the Tizen main context.
Preserve delayed execution, posting order, worker-thread scheduling, re-entrant callbacks, and source cleanup. Remove the remaining Ecore dependency from display refresh reporting by using the existing 60 Hz constant.
#146