Skip to content

Normalize changelogs - #12520

Open
guidezpl wants to merge 13 commits into
mainfrom
fix-changelogs
Open

Normalize changelogs#12520
guidezpl wants to merge 13 commits into
mainfrom
fix-changelogs

Conversation

@guidezpl

@guidezpl guidezpl commented Aug 20, 2026

Copy link
Copy Markdown
Member

To avoid churn, not bumping versions or releasing.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions Bot added p: shared_preferences p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package p: interactive_media_ads Plugin for IMA SDK p: vector_graphics p: google_adsense p: google_fonts triage-framework Should be looked at in framework triage triage-engine Should be looked at in engine triage p: google_identity_services p: cupertino_ui p: material_ui triage-design Should be looked at in design triage labels Aug 20, 2026
@guidezpl guidezpl added override: no versioning needed Override the check requiring version bumps for most changes override: allow changelog edit labels Aug 20, 2026
@github-actions github-actions Bot removed override: no versioning needed Override the check requiring version bumps for most changes override: allow changelog edit labels Aug 20, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request normalizes the changelog entries across multiple packages to consistently use present-tense verbs and end with a period. It also updates the version and changelog validator tool to support a new override: allow changelog edit label, which permits direct edits to CHANGELOG.md files in packages that use batch releases, and adds a corresponding test. The review feedback highlights several grammatical errors and style guide inconsistencies introduced by the automated normalization, such as incorrect verb tenses, double periods, and awkward phrasing resulting from direct verb substitutions.

Comment thread packages/animations/CHANGELOG.md Outdated
Comment thread packages/camera/camera/CHANGELOG.md Outdated
Comment thread packages/camera/camera_android/CHANGELOG.md Outdated
Comment thread packages/go_router_builder/CHANGELOG.md Outdated
Comment thread packages/google_identity_services_web/CHANGELOG.md Outdated
Comment thread packages/video_player/video_player/CHANGELOG.md
guidezpl and others added 3 commits August 20, 2026 18:30
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@guidezpl guidezpl added override: no versioning needed Override the check requiring version bumps for most changes override: allow changelog edit override: batch-go_router label used for post release sync override: batch-cupertino_ui cupertino_ui batch release PR override: batch-material_ui material_ui batch release PR and removed override: allow changelog edit labels Aug 20, 2026
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

What problem are you trying to solve with this PR? The CHANGELOG is a client-facing history; rewriting old entries seems inconsistent with that. Historically we've only made textual changes to old entries when we are adding a notice that a version was retracted.

The policy was written to normalize new entries going forward, so the fact that entries that predate the policy don't follow the policy isn't something we consider a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants