Skip to content

Ignore shared code for iOS platform implementation of Google Maps plugin - #12529

Open
guidezpl wants to merge 1 commit into
mainfrom
analyzer-cleanup
Open

Ignore shared code for iOS platform implementation of Google Maps plugin#12529
guidezpl wants to merge 1 commit into
mainfrom
analyzer-cleanup

Conversation

@guidezpl

Copy link
Copy Markdown
Member

There are hundreds of analyzer errors surfaced by this directory since it has no pubspec. Exclude it from analysis

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates analysis_options.yaml to exclude the google_maps_flutter_ios_shared_code directory from static analysis. Feedback suggests that excluding this directory prevents static analysis of Dart files within it, and recommends adding a minimal pubspec.yaml file to the directory instead to properly resolve analyzer errors.

Comment thread analysis_options.yaml
Comment on lines +27 to +28
# Ignore shared code for iOS platform implementation of Google Maps plugin.
- 'packages/google_maps_flutter/google_maps_flutter_ios_shared_code/**'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Excluding the entire google_maps_flutter_ios_shared_code directory from analysis prevents any Dart files within it (such as Pigeon definitions or utility scripts) from being statically analyzed and linted. This can lead to undetected compilation errors or code bitrot over time.

Instead of excluding the directory, a more robust approach to resolve the analyzer errors is to add a minimal pubspec.yaml file to packages/google_maps_flutter/google_maps_flutter_ios_shared_code/ with publish_to: 'none' and the necessary dependencies. This will allow the Dart analyzer to correctly resolve imports and analyze the Dart files in this directory.

@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Exclude it from analysis

What's the context where analysis is being run on it in the first place? It's not a package, so our tooling ignores it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants