[material_ui] Port flutter/flutter #190810 fix dismissal near minimum extent when shouldCloseOnMinExtent - #12545
Open
kirya355 wants to merge 1 commit into
Open
[material_ui] Port flutter/flutter #190810 fix dismissal near minimum extent when shouldCloseOnMinExtent#12545kirya355 wants to merge 1 commit into
kirya355 wants to merge 1 commit into
Conversation
…uldCloseOnMinExtent Port of flutter/flutter#190810.
github-actions
Bot
added
p: material_ui
triage-design
10 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the bottom sheet dismissal logic in bottom_sheet.dart and scaffold.dart to check if the difference between the current extent and the minimum extent is within precisionErrorTolerance, rather than using direct equality. It also adds unit tests to verify this behavior and a pending changelog entry. The review feedback suggests removing the .abs() call from the tolerance check to ensure the bottom sheet still closes if the extent is dragged or animated below the minimum extent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports flutter/flutter#190810 by @kirya355 from flutter/flutter to flutter/packages.