Skip to content

[material_ui] Remove !chrome in text_field_test.dart - #12548

Open
ValentinVignal wants to merge 1 commit into
flutter:mainfrom
ValentinVignal:material-ui/test/remove-no-chrome-in-text-field-tests
Open

[material_ui] Remove !chrome in text_field_test.dart#12548
ValentinVignal wants to merge 1 commit into
flutter:mainfrom
ValentinVignal:material-ui/test/remove-no-chrome-in-text-field-tests

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#92134

It seems the issue is already closed and fixed, so I'm attempting to remove this TODO

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Aug 22, 2026
@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @TestOn('!chrome') annotation and the associated TODO comment from packages/material_ui/test/text_field_test.dart, enabling the test suite to run on Chrome. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant