Skip to content

[material_ui] Fix LocalHistoryEntry leak when double tapping Drawer scrim - #12552

Draft
Mairramer wants to merge 6 commits into
flutter:mainfrom
Mairramer:fix-drawer-double-tap
Draft

[material_ui] Fix LocalHistoryEntry leak when double tapping Drawer scrim#12552
Mairramer wants to merge 6 commits into
flutter:mainfrom
Mairramer:fix-drawer-double-tap

Conversation

@Mairramer

Copy link
Copy Markdown
Contributor

This PR improves the DrawerControllerState lifecycle by making sure the LocalHistoryEntry is properly removed and cleared.

Fixes flutter/flutter#133740

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@github-actions github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 22, 2026
@Mairramer Mairramer changed the title Fix LocalHistoryEntry leak when double tapping Drawer scrim [material_ui] Fix LocalHistoryEntry leak when double tapping Drawer scrim Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: material_ui triage-design Should be looked at in design triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tapping outside of drawer twice to dismiss it breaks swipe to go back

1 participant