[mmohankrishna-lab]

Fixes an issue where pressing the Escape key does not close a MenuAnchor menu that was opened by a tap or click when childFocusNode is not provided.

Root Cause

1. When a MenuAnchor is opened via a tap or click (e.g. from a TextButton or IconButton) without a childFocusNode, the button does not request focus on tap and RawMenuAnchorState.open only requests focus on widget.childFocusNode. As a result, FocusManager.instance.primaryFocus remains outside both RawMenuAnchor and _Submenu, so key events never route through their Shortcuts or Actions widgets.
2. In _Submenu.build, FocusScope(node: anchor._menuScopeNode) was placed above Actions and Shortcuts, so even when _menuScopeNode itself had primary focus, key events walked up past FocusScope without passing through _Submenu's Shortcuts and Actions.

Fix

1. Wrap FocusScope(node: anchor._menuScopeNode) inside Actions and Shortcuts in _Submenu.build so key events dispatched to _menuScopeNode walk up through _kMenuTraversalShortcuts and DismissMenuAction.
2. In _MenuAnchorState._handleMenuOpenRequest, when a root menu opens without a childFocusNode and focus is not already inside the MenuAnchor subtree, move focus to _menuScopeNode via FocusScope.of(context).setFirstFocus(_menuScopeNode) (and detach _menuScopeNode cleanly if closed/disposed before FocusScope mounts).

Fixes flutter/flutter#195059

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I followed the version and CHANGELOG instructions, using semantic versioning and the repository CHANGELOG style, or I have commented below to indicate which documented exception this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

[gemini-code-assist]

Code Review

This pull request modifies MenuAnchor to manage focus when opened by a tap or click, ensuring that pressing Escape closes the menu. It also adjusts the widget hierarchy in _Submenu and adds corresponding regression tests. Review feedback suggests adding a mounted check in the close animation's completion callback to prevent potential crashes upon disposal, removing redundant detach logic in dispose, and simplifying the focus request logic by removing dead code.

[navaronbracke]

LGTM with nit