Repository navigation
Conversation
11 tasks done
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DataTable cell semantics regression test to assert the cell's composed rect from the root of the semantics tree, introducing a helper method _semanticsWorldRect to traverse the semantics tree. The review feedback suggests adding explicit checks and descriptive error messages in this helper method to handle cases where semantics are not enabled or the target node is not found, preventing generic null check errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the Material-side test change of flutter/flutter#195288, following the porting instructions in flutter/flutter#188444 (Material is frozen in flutter/flutter; its tests now live here).
What this PR changes
The
DataTable cell has correct semantics rectregression test (flutter/flutter#171264) asserted the internal transform distribution of the table's synthesized semantics nodes: that the labeled cell node carriestransform = nullwith an origin-based rect. That shape is an implementation detail — the same assistive-technology-visible box can be produced with the transform living on the cell's own node instead of on a synthesized ancestor.The assertion now composes the transform chain from the root of the semantics tree and checks the laid-out cell box
(0, 56) → (302, 126)directly. That holds regardless of how the table distributes transforms between its synthesized row/cell nodes and the cell's own node, while still catching the #171264 bug class (a wrong cell box).Verified against both the current Flutter framework and the pending framework change in flutter/flutter#195288: the test passes on either, so this PR can land independently of that one.
Issues fixed
test/materialside of Fix table cell semantics offsets across assemble passes flutter#195288 (per the freeze-porting process in [Decoupling] Port over open PRs from flutter/flutter to material_ui or cupertino_ui flutter#188444).Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2