Conversation
Add the --override-manager-before-dry-run flag, wiring the named field managers into ssa ApplyCleanupOptions.FieldManagersBeforeDryRun so their ownership is reclaimed before the server-side apply dry-run. The existing --override-manager takeover runs only after a successful dry-run, so it cannot recover an object wedged at dry-run validation by a stale or foreign manager that co-owns a required field (for example, a legacy full-object PUT left behind by a break-glass workflow). The new flag repairs ownership before the dry-run so the merge is valid. The pre-dry-run list is kept separate from --override-manager because the takeover mutates managedFields before validation; the always-on default managers stay on the post-dry-run cleanup path to preserve their transactional behavior. Signed-off-by: Dipti Pai <diptipai89@outlook.com> Assisted-by: GitHub Copilot/Claude Opus 4.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the --override-manager-before-dry-run flag, wiring the named field managers into ssa ApplyCleanupOptions.FieldManagersBeforeDryRun so their ownership is reclaimed before the server-side apply dry-run.
The existing --override-manager takeover runs only after a successful dry-run, so it cannot recover an object wedged at dry-run validation by a stale or foreign manager that co-owns a required field (for example, a legacy full-object PUT left behind by a break-glass workflow). The new flag repairs ownership before the dry-run so the merge is valid.
The pre-dry-run list is kept separate from --override-manager because the takeover mutates managedFields before validation; the always-on default managers stay on the post-dry-run cleanup path to preserve their transactional behavior.
Assisted-by: GitHub Copilot/Claude Opus 4.8
Fixes: #1722