Repository navigation
Check artifact paths in storage deletion tests - #2231
Open
doomfrawen wants to merge 1 commit into
Open
doomfrawen wants to merge 1 commit into
doomfrawen wants to merge 1 commit into
Conversation
Strip the absence marker before constructing artifact paths in the storage test assertions, so negative checks inspect the intended files. Assisted-by: Codex/GPT-6 Signed-off-by: Ernesto Honigmann <Ernest@honigmann.ca> Signed-off-by: doomfrawen <doomfrawen@users.noreply.github.com>
doomfrawen
marked this pull request as ready for review
November 6, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2229.
Storage tests use a leading
!to mark artifacts expected to be absent. The assertion loops retain that marker in the filesystem path, so negative checks inspect a different location. Strip it before joining the path in the five controller storage test suites.Validation:
make tidy fmt vetandgit diff --checkpassed.make testpassed in fork CI for commitc0e6439(11m 8s total, using the upstream workflow configuration).Prepared with Codex assistance (
Assisted-by: Codex/GPT-6).