Repository navigation
Run go fix as part of the test workflow - #406
Merged
Merged
Conversation
Run go fix in the root and API modules before tests so the CI dirty check also enforces source modernization. Apply the resulting fixes. Set rendered artifact names on the local OutputArtifact copy before embedding it to avoid conflicting promoted-field initializers. Signed-off-by: haramjeong <04harams77@gmail.com> Assisted-by: Codex/GPT-6
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
matheuscscp
force-pushed
the
ci/run-go-fix-in-tests
branch
from
November 14, 2026 15:17
19ae118 to
5dfc8f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fluxcd/flux2#6120 (source-watcher).
Run
go fix ./...in both Go modules as part ofmake test, before the existing CI dirty-tree check. Include the generated source changes and the resultinggo mod tidyupdate.In
renderArtifactRequest, set the rendered name and namespace on the localOutputArtifactcopy before embedding it. Otherwise Go 1.27.0's fix pass combines those assignments into a literal that specifies both the embedded value and its promoted fields, which does not compile.Validation on macOS arm64 with Go 1.27.0:
make tidy fmt vet test manager.go test ./....go fixleaves the committed tree unchanged.The Docker/Kind deployment steps are left to CI; the local Docker daemon is not running.
AI assistance: Codex/GPT-6.