Repository navigation
web-e2e: discover the delayed proxy package with Refresh from upstream, so the proxy-delay spec passes again - #860
Merged
Conversation
Since #841 (#836), a proxy's package page answers from what the proxy has cached and asks no upstream: GET /browse/packages/{repo}/{id} of a package the proxy holds nothing of is a 404, and looking no longer discovers it. The proxy-delay spec discovered the upstream's Sample.Lib by that GET, so it failed with a 404 and web-e2e failed on main. The spec now follows the page's own flow: it opens the package page, sees Package not cached, clicks Refresh from upstream, and finds the version row with the delayed badge; the detail API, from the cache now, surfaces the version as delayed_until. The first look waits out the detail query's two retries of the 404. fetchPackageDetail's comment no longer says the read discovers a proxy's package. Fixes #858 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012e6DJbCpYhgvM3SxcYuMD1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #858
Problem
Since #841 (#836), a proxy's package page answers from what the proxy has cached and asks no upstream:
GET /browse/packages/{repo}/{id}of a package the proxy holds nothing of is a 404, and looking no longer discovers it. The proxy-delay spec discovered the upstream'sSample.Libthrough that GET, so it failed on everymainrun since 28f7b14:Change
The spec now follows the page's own flow, which #841 added:
/packages/<proxy>/sample.liband sees Package not cached (looking does not discover the package). This first check waits up to 15 s, because the detail query retries the 404 twice before the page shows it;POST …/refresh), which asks the upstream as a client's install does and stamps the version'sfirst_seen_at;1.2.3row with the delayed badge, and the detail API, from the cache now, surfaces the version asdelayed_until;fetchPackageDetail's comment inweb/e2e/helpers.tsno longer says the read discovers a proxy's package.Test-only, so no changelog fragment, as in #783.
Testing
web-e2eruns onmainand in the merge queue only, not on pull requests, so this ran locally the way CI runs it (CI=1 pnpm exec playwright test, Postgres 18 and versitygw throughmirror.gcr.io, the debugforge-server):proxy-delay.spec.ts: passes (5.1 s), no retry;Generated by Claude Code