[xperiandri]

Proposed Changes

The agent instructions contradicted each other on test categories:

• .github/copilot-instructions.md, Testing section: asked for an operation category on every test method through [<TestMethod; TestCategory(nameof Queue.enqueue)>], with specialized attributes added next to it on the method.
• .github/instructions/test-categories.instructions.md, path-scoped: forbids a category written as a string in [<TestCategory "...">]. nameof produces such a string. These rules put the attribute of the operation or component that a class examines on the class.

Changes:

• Testing section: it no longer has its own category bullets. The path-scoped rules are the only source.
• Path-scoped rules: the first rule now also says to declare each test category as a TestCategoryBaseAttribute descendant.

The rule after this change: a test class carries TestCategoryBaseAttribute descendants for the collection and for the component or area that it examines, such as [<TestClass; FlatListTestCategory; BuilderTestCategory>]. Test methods carry no categories.

Types of changes

What types of changes does your code introduce to FSharp.Collections.Immutable?
Put an x in the boxes that apply

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Agent instructions only; no code changes.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• Build and tests pass locally (not applicable – two Markdown files)
• I have added tests that prove my fix is effective or that my feature works (not applicable)
• I have added necessary documentation (if appropriate)

Further comments

The tests on main carry no categories yet. The ADR 0001 pull requests (#25 onwards) still put TestCategory (nameof …) on their test methods and check it in TestCategoriesTests. They will follow this rule: categories on the classes only, and the convention test checks the classes.

🤖 Generated with Claude Code

[Copilot]

🟢 Approval recommended

The documentation-only changes consistently clarify the category rules and have no unresolved findings.

No open issues 🎉

What changed in this PR

Resolves conflicting test-category guidance by making the path-scoped instructions the single source for class-level categories.

Changes:

• Removes method-level category requirements from the general instructions.
• Explicitly requires custom categories derived from TestCategoryBaseAttribute.

File	Description
.github/​instructions/​test-categories.instructions.md	Clarifies the required category base type.
.github/​copilot-instructions.md	Removes conflicting category guidance.

_{Review effort: Balanced}

[xperiandri]

Folded into main instead, in the commits that introduced the text:

• the Testing section change went into chore(ai): expand and restructure Copilot instructions;
• the path-scoped rule went into chore(ai): add path-scoped instructions for test categories.

The tree of main (17f93b7) is now identical to this branch, so this pull request is no longer needed.