Fix stability, resource, and correctness bugs#1780
Open
Thorium wants to merge 1 commit into
Open
Conversation
Thorium
commented
Jul 6, 2026
Member
- HTML: decode hex charrefs (A) correctly; clamp table colspan/rowspan to spec limits (was OverflowException/OOM/hang on malicious spans); stack-safe HtmlNode.ToString (was uncatchable StackOverflow at ~5k nesting depth)
- HTTP: CombinedStream no longer treats partial reads as EOF (silent multipart truncation) and drops the 2GB int overflow; Range supports bytes=N-/-N; body streams disposed even when an upload faults
- CSV: skipRows survives re-enumeration of Rows; Save quotes headers, lone CR, and all document separators (round-trip corruption); Save(TextWriter) no longer disposes the caller-owned writer; reentrant enumeration synchronized
- JSON: NaN/inf/1e300 floats route through JsonValue.Float instead of throwing OverflowException; stray '/' no longer swallowed as whitespace
- Caching/IO: no Int32 overflow for >24.8-day expirations (could crash host); atomic temp-file-then-rename cache writes; conditional expiry removal; file-watcher subscriptions locked (IDE crash risk)
- WorldBank: HTTP-200 error bodies validated before caching (30-day cache poisoning); empty topics no longer throw KeyNotFoundException; URL segments escaped with EscapeDataString (path injection)
- XML: CreateRecord no longer corrupts structure for same-named nested paths
- DesignTime: Interlocked instance ids, locked dispose-action set, web cache key includes Encoding/row-limit parameters
- HTML: decode hex charrefs (A) correctly; clamp table colspan/rowspan to spec limits (was OverflowException/OOM/hang on malicious spans); stack-safe HtmlNode.ToString (was uncatchable StackOverflow at ~5k nesting depth) - HTTP: CombinedStream no longer treats partial reads as EOF (silent multipart truncation) and drops the 2GB int overflow; Range supports bytes=N-/-N; body streams disposed even when an upload faults - CSV: skipRows survives re-enumeration of Rows; Save quotes headers, lone CR, and all document separators (round-trip corruption); Save(TextWriter) no longer disposes the caller-owned writer; reentrant enumeration synchronized - JSON: NaN/inf/1e300 floats route through JsonValue.Float instead of throwing OverflowException; stray '/' no longer swallowed as whitespace - Caching/IO: no Int32 overflow for >24.8-day expirations (could crash host); atomic temp-file-then-rename cache writes; conditional expiry removal; file-watcher subscriptions locked (IDE crash risk) - WorldBank: HTTP-200 error bodies validated before caching (30-day cache poisoning); empty topics no longer throw KeyNotFoundException; URL segments escaped with EscapeDataString (path injection) - XML: CreateRecord no longer corrupts structure for same-named nested paths - DesignTime: Interlocked instance ids, locked dispose-action set, web cache key includes Encoding/row-limit parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.