SubjectSummaryにrequirementsフィールドを追加 - #67
Open
zakiPoteto wants to merge 3 commits into
Open
Conversation
一覧APIで必修科目を判定できるようにするため、詳細用モデルSubjectDetailにのみ存在していたrequirementsをSubjectSummaryにも追加する。 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESKebxSqfazc45RBCJCGVh
zakiPoteto
requested review from
a team,
KurenNagata,
hikaru-0602,
kantacky,
masaya-osuga,
suzukimifuyu,
takuyone68 and
tanakarinna
September 8, 2026 02:50
Member
|
@zakiPoteto |
科目検索画面(search_subject_reducer.dart)がgetSubjects/getCourseRegistrations/ getTimetableItemsの3エンドポイントをクライアント側でマージしている問題への対応。 新エンドポイントを生やすのではなく、既存のGET /v1/subjectsが返すモデル自体に 必要なフィールドを追加する形にした。 - academic-api: SubjectにisRegistered?/slots?を追加、SubjectsV1.listにuserId?を追加 - app-bff-api: SubjectSummaryにisRegistered/slotsを追加 (GET /v1/subjectsは未ログインでも呼び出せる仕様を維持。Bearerトークンがある場合のみ isRegisteredをユーザー基準で計算し、無い場合は全科目falseを返す) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018TpGeornAqcXew3fPTb6A6
This reverts commit 8340f2d.
2 tasks
Author
@kantacky さん
該当PR: #70 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubjectSummaryに、詳細用モデルSubjectDetailにのみ存在していたrequirementsフィールドを追加academic-api側のSubject.requirements?は既にoptionalなlist/detail共通モデルのため変更不要（確認済み）Test plan
tsp compile .が成功することを確認tsp-output/schema/openapi.AppBFFService.yamlのSubjectSummaryにrequirements（必須項目）が追加されていることを確認distribute-yaml.ymlを手動workflow_dispatchで実行しスキーマを配布server側handler/converter_subject.goのsubjectToAPIにRequirements追加は別PRで対応