Repository navigation
BUG FIX: Shut down relaunched cluster workers when the plan is stopped - #839
Open
Arthur031221 wants to merge 1 commit into
Open
Arthur031221 wants to merge 1 commit into
Arthur031221 wants to merge 1 commit into
Conversation
Arthur031221
force-pushed
the
fix-relaunched-worker-leak
branch
from
October 7, 2026 06:03
a378f8c to
c0aa040
Compare
Author
|
Rebased onto |
Arthur031221
force-pushed
the
fix-relaunched-worker-leak
branch
from
October 9, 2026 00:33
c0aa040 to
0fd7384
Compare
When a cluster worker is terminated (for example by cancel()) and then relaunched, the new node was stored in the backend but not in the cluster registry. stopCluster() then closed the old node and left the relaunched worker process and its connection open until garbage collection.
Arthur031221
force-pushed
the
fix-relaunched-worker-leak
branch
from
October 10, 2026 05:29
0fd7384 to
35e9f08
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a cluster worker is cancelled and relaunched, switching to a sequential plan leaves its connection open. The backend holds the replacement node, but the cluster registry still holds the old one.
The registry now gets updated when a worker is relaunched, so shutting down the plan closes the replacement connection. Only clusters owned by the registry are updated.
Added a cancel/relaunch regression test. Tested with
R CMD check --no-manual --as-cran future_1.76.0-9007.tar.gz.Assisted by Claude/Codex.