feat: add an option in Stackable setting to use unrestricted link con… - #3756
Open
Arukuen wants to merge 1 commit into
Open
feat: add an option in Stackable setting to use unrestricted link con…#3756Arukuen wants to merge 1 commit into
Arukuen wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughAdds an editor setting and admin toggle for unrestricted URL input. Link controls now select WordPress ChangesUnrestricted URL input
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant AdminSettings
participant EditorSettings
participant LinkControl
participant URLInput
AdminSettings->>EditorSettings: save stackable_enable_unrestricted_url_input
EditorSettings-->>LinkControl: provide editor setting
LinkControl->>URLInput: render when unrestricted input is enabled
URLInput-->>LinkControl: return changed URL value
Merge Risk: ⚪ Minimal · up to This adds an opt-in unrestricted URL field for Stackable link controls while preserving the existing control by default. The setting and UI wiring are consistent, with no identified merge-blocking impact. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🤖 Pull request artifacts
|
|
Size Change: +385 B (+0.01%) Total Size: 2.64 MB 📦 View Changed
ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…trol
Adds an Use Unrestricted URL Input setting under Stackable Settings > Editor Settings.
By default, the setting is off. Normal users remain on Gutenberg’s current LinkControl with its existing validation and workflow unchanged.
When enabled, all Stackable link controls use the legacy direct URL input, allowing shortcodes, template tokens, and other dynamic URL values that Gutenberg rejects.
Summary by CodeRabbit
New Features
Bug Fixes