feat(cli): add GANDER_CONFIG profile selector for non-prod gandermd - #55
Merged
Conversation
configPath() now honors GANDER_CONFIG=<name> by reading and writing ~/.gander.<name> instead of ~/.gander. The two files are fully isolated — no field-level mutation, no WriteConfig workaround — so running the CLI against a local dev or staging gandermd never disturbs the prod profile. Profile names are validated: rejects '.', '..', '/', '\' to prevent path traversal. The legacy ~/.mdp fallback still applies to the default profile but never to named profiles. Closes #54.
Collaborator
Author
|
/oc please review this PR and approve if you find it ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configPath()now honorsGANDER_CONFIG=<name>→ reads and writes~/.gander.<name>instead of~/.gander. The two files are fully isolated — no field-level mutation, noWriteConfigworkaround — so running the CLI against a local dev or staging gandermd never disturbs the prod profile..,..,/,\). Legacy~/.mdpfallback still applies to the default profile only..mdpbypass for named profiles.Paired with
gandermd/gandermd#37 — server-side
make devworkflow that usesGANDER_CONFIG=devvia abin/gander-localwrapper. Pergandermd/AGENTS.md("CLI pairing"), ship in the same release cycle.Local loop after merge
Prod
ganderon$PATHkeeps using~/.gander. The wrapper only exists atbin/gander-localin the server repo.~/.ganderand~/.gander.devnever interact.Acceptance criteria
GANDER_CONFIG=dev gander signup --email foo@bar.comcreates~/.gander.dev;~/.ganderis byte-identical before and after.GANDER_CONFIG=dev gander share README.mdposts tolocalhost:7331and persists share mapping into~/.gander.dev.GANDER_CONFIG, behavior is identical to before — including the.mdplegacy fallback.GANDER_CONFIG=../escapeerrors out cleanly.Closes #54.