feat(cli): add --comments, --private, and --no-comments - #97
Open
scott wants to merge 1 commit into
Open
Conversation
Omit each policy JSON key unless the flag is set so a content refresh does not clobber share ACL. --no-comments aliases --comments team. Old servers that drop the fields error instead of printing a URL. Closes #96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--comments=anyone|team,--comment-visibility=public|team,--private, and--no-commentstogander shareandgander watch.flag.Visit), so a content refresh does not clobber stored ACL.--no-commentsis an alias for--comments team.--privatesends onlydoc_visibility=privateunless other flags are set.--no-comments/--privatewith--comments anyone,anyone+ team threads, private + public threads) fail before HTTP.gandermd does not support --comments; upgrade the server) instead of printing a URL.gander listgains COMMENTS (anyone/team), THREADS (public/team), and PRIVATE (yes/blank). Watch PUTs stay{content}only.Related Issue
Closes #96
Supersedes #93 (
--no-comments/comments_enabled). Server issue #61 was closed; there is nocomments_enabledcolumn.Pairing
Blocked on the post-dashboard gandermd being deployed to
:latest(readJSON+DisallowUnknownFields400s these fields against today's server).:latest)Do not merge this until that stack is on
:latest.Testing
All green. Coverage includes omit vs send,
--no-comments≡--comments team,--privatebody, watch PUT content-only, invalid combos before HTTP, old-server echo check, and list columns.Notes
No invite subcommand in v1. Token-only authors change policy by re-sharing with flags.