Rewrite IsAspherical - #158
Conversation
... to use higher level polymaking interfaces; this makes it more robust (e.g. it catches and reports errors, unlike `Exec`), and also compatible with future improvements to polymaking.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 43.84% 43.82% -0.02%
==========================================
Files 364 364
Lines 66466 66443 -23
==========================================
- Hits 29141 29118 -23
Misses 37325 37325
🚀 New features to boost your workflow:
|
|
@grahamknockillaree I hope this is OK for you. Having this in HAP would make it much easier to make some major improvements to the polymaking package :-) |
|
Thanks @grahamknockillaree for merging. Would you terribly mind making a release with this? By the way, did I ever tell you about our release action that makes making a release easier than with the old ReleaseTools? Basically, you have to update the package version and date in PackageInfo.g and commit & push that go git; and then press a button on GitHub... There is ed details, step-by-step guide with screenshots here: https://github.com/gap-actions/release-pkg (the action has already been set up on this repository). |
2 participants
... to use higher level polymaking interfaces; this makes it more
robust (e.g. it catches and reports errors, unlike
Exec), andalso compatible with future improvements to polymaking.