Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Focus695
marked this pull request as ready for review
September 12, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engineering reviews currently persist test plans, dashboard metadata, and a durable architecture decision, but a complete findings document is not required when GBrain is unavailable. Ending the session can still lose issue details, user choices, diagrams, and implementation order.
Require
/plan-eng-reviewto save those findings under the resolved state root'sprojects/<slug>/eng-reviews/directory after the interactive review. Records include target and commit metadata, preserve unresolved decisions and suppressed findings, avoid filename collisions, and are read back before reporting success. Resume guidance treats saved findings as historical context and checks current target contents and commit before reuse.This is a scoped follow-up to #721, rebuilt on current main (71f6048). It carries forward only the local findings document. The old upgrade overlay is omitted: current upgrades use fast-forward/autostash and a separate rendering flow, so the old copy-over approach needs a separate design. This PR does not claim that all customization persistence cases are solved.
Validation:
--dry-runfreshness checks.git diff --check.gen-skill-docs,skill-validation,template-context-parity, andcontext-budget-ratchet.