Fix: walkMd lacks symlink cycle detection causing infinite recursion - #2890
Open
asmit25805 wants to merge 1 commit into
Open
asmit25805 wants to merge 1 commit into
asmit25805 wants to merge 1 commit into
Conversation
Open
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds symlink cycle detection to walkMd by tracking realpaths in a visited Set, mirroring the existing guard in findSkillDirs. Symlinks to directories are resolved via realpathSync before recursing, and already-visited directories are skipped to prevent infinite recursion.
Kept the change minimal — just what's needed for the fix, nothing else touched.
Closes #203