Boot-up B register values

[dmitry-shechtman]

Unifies #72 and #74 as requested.

[Rangi42]

The BOOTUP_B_CGB and BOOTUP_B_AGB constants have been around since hardware.inc v3.0. They should still be defined in hardware_compat.inc.

[dmitry-shechtman]

I'm not sure if that would be a good idea, since they are being removed for a reason.

[Rangi42]

Everything in hardware_compat.inc was removed for a reason. It's there for backwards compatibility.

[dmitry-shechtman]

Actually, it might be a good idea to add a comment in hardware_compat.inc with an explanation for every significant change, such as this one.

Commented

[Rangi42]

Actually, it might be a good idea to add a comment in hardware_compat.inc with an explanation for every significant change, such as this one.

Maybe so; some already have such comments, e.g. the ones suggesting RGBASM-feature alternatives.

[dmitry-shechtman]

Maybe so; some already have such comments, e.g. the ones suggesting RGBASM-feature alternatives.

So do we agree on this warranting a separate line with a comment?

[Rangi42]

LGTM, thank you! I'm not actually merging it yet because:

• We have multiple ongoing PRs, it might be convenient to iron them all out, then merge all at once and call it a new release
• This removes some constants from hardware.inc and so is a breaking change, needing version number 6.0
• When we get around to 6.0 I also want to fix Rename _AUD3WAVERAM to AUD3WAVERAM #64

[dmitry-shechtman]

Since we're already breaking it, please consider updating hardware.inc to use S_* for consistency.

[avivace]

LGTM as well

[avivace]

@Rangi42 do we have a PR for #64 ?

[Rangi42]

Thank you for this fix!