Skip to content

[MEDIUM] Free COPY buffers when decoders raise #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larskanis merged 1 commit into from
Sep 3, 2026
+28 −2
Merged

[MEDIUM] Free COPY buffers when decoders raise #742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions ext/pg_connection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2824,6 +2824,31 @@ pgconn_sync_put_copy_end(int argc, VALUE *argv, VALUE self)
return (ret) ? Qtrue : Qfalse;
}

struct pgconn_copy_data {
t_pg_coder *coder;
char *buffer;
int length;
int enc_idx;
};

static VALUE
pgconn_decode_copy_data(VALUE data_ptr)
{
struct pgconn_copy_data *data = (struct pgconn_copy_data *)data_ptr;
t_pg_coder_dec_func dec_func = pg_coder_dec_func(data->coder, data->coder->format);

return dec_func(data->coder, data->buffer, data->length, 0, 0, data->enc_idx);
}

static VALUE
pgconn_free_copy_data(VALUE data_ptr)
{
struct pgconn_copy_data *data = (struct pgconn_copy_data *)data_ptr;

PQfreemem(data->buffer);
return Qnil;
}

static VALUE
pgconn_sync_get_copy_data(int argc, VALUE *argv, VALUE self )
{
Expand Down Expand Up @@ -2858,8 +2883,9 @@ pgconn_sync_get_copy_data(int argc, VALUE *argv, VALUE self )
}

if( p_coder ){
t_pg_coder_dec_func dec_func = pg_coder_dec_func( p_coder, p_coder->format );
result = dec_func( p_coder, buffer, ret, 0, 0, this->enc_idx );
struct pgconn_copy_data data = { p_coder, buffer, ret, this->enc_idx };

return rb_ensure(pgconn_decode_copy_data, (VALUE)&data, pgconn_free_copy_data, (VALUE)&data);
} else {
result = rb_str_new(buffer, ret);
}
Expand Down
Loading