Skip to content

fix: sign proof-bearing validator joins - #405

Open
MuncleUscles wants to merge 3 commits into
v0.40-devfrom
fix/validator-registration-proof
Open

fix: sign proof-bearing validator joins#405
MuncleUscles wants to merge 3 commits into
v0.40-devfrom
fix/validator-registration-proof

Conversation

@MuncleUscles

@MuncleUscles MuncleUscles commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • build chain/factory/owner-bound operator possession proofs for liquid and vesting validator joins
  • reuse the already-decrypted owner key, or require --operator to match an imported local CLI account
  • keep browser-wallet ownership while signing the operator proof with the selected local operator keystore
  • add --operator-password for non-interactive selected-operator proof signing
  • update interactive, non-interactive, unit, and browser-tier paths to the proof-bearing SDK API

Root cause

Consensus #1285 removed the address-only validator join overloads. The CLI still called the retired validatorJoin({amount, operator}) and vestingValidatorJoin({vesting, operator, amount}) surfaces, so tooling joins could not enter the proof-bearing validator wallet factory.

Validation

  • npm run build
  • focused staking, wizard, and vesting suites: 95/95
  • full unit suite: 792/792
  • affected Tier 2 browser E2E: 6/6
  • git diff --check

Depends-On: https://github.com/genlayerlabs/genlayer-consensus/pull/1285

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fd35a6a1-2b38-4d45-bed6-f894963317d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MuncleUscles
MuncleUscles marked this pull request as ready for review August 9, 2026 15:40
@MuncleUscles
MuncleUscles requested a review from cgmello August 9, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant