fix: harden Wasmtime integration - #14
Draft
MuncleUscles wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MuncleUscles
force-pushed
the
pr/v0.3/codex/wasmtime-hardening
branch
from
July 31, 2026 09:44
1ebef38 to
2e96b35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Storeconstructors and upstream test compatibilityWhy
The previous integration combined an old Wasmtime pin, runtime-derived validation features, unsafe loading of mutable precompiled artifacts, a fork-wide
StoreAPI break, and fingerprint collisions when multiple instances shared a module name. In a consensus-critical executor these are security, determinism, compatibility, and observability risks.The initial implementation targeted 42.0.2. A live advisory check identified GHSA-p8xm-42r7-89xg / RUSTSEC-2026-0114, for which no fixed 42.x release exists. This PR therefore uses 43.0.2, the closest patched line. OSV checks for both version 43.0.2 and its exact upstream commit return no published advisories.
Validation
cargo fmt --manifest-path executor/Cargo.toml -- --checkcargo test -p wasmtime --tests: complete upstream Wasmtime test suite passed (158 tests passed, 1 ignored)Review notes
The on-disk precompile command now fails closed until artifacts have immutable, authenticated provenance. The in-memory compiled-module cache remains enabled.