test: expose runner dependency and validation regressions - #17
Draft
MuncleUscles wants to merge 6 commits into
Draft
test: expose runner dependency and validation regressions#17MuncleUscles wants to merge 6 commits into
MuncleUscles wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds failing regression coverage for eighteen runner dependency, validation, and precompile-cache issues.
This PR is intentionally test-only. It is stacked on #16 and does not change production behavior.
Regressions captured
Depends: contractis processed again because the root is not initially present in the dependencyvisitedset; the integration fixture observes an unexpected second, cached load of the same root runnerRegisterRunnerreturns acustom:ID and pins a runner whoserunner.jsonaction cannot be deserialized, deferring the malformed-runner error until later useRegisterRunneraccepts and pins a runner that explicitly declares a GenVM major incompatible with the current executorSetArgsaccepts an embedded NUL and serializes an argument whose WASI buffer terminates before the complete runner-supplied valueAddEnvaccepts names containing=or NUL and values containing NUL, producing ambiguous or prematurely terminated WASI environment entriesMapFileaccepts an empty destination and creates an unreachable empty-name VFS entryMapFiledestination such as/./vm/secretpasses the protected/vmguard even though it normalizes into that treefile\0ignoredinstead of the standard namefilegenvm checkpanics on a registry runner hash shorter than two characters instead of returning an installation errorgenvm checkaccepts a registry runner name such as../outside, allowing artifact validation outside the configured runners directoryRelative
MapFiledestinations are intentionally not rejected here: the stable ZIP integration fixture currently relies on one.Validation
charged, then unexpectedcached)Ok(custom:...)runners_dir0777directorygenvmbinary regression tests are isolated; no unrelated binary tests existScope