Skip to content

test(storage): cover final slot byte - #18

Draft
MuncleUscles wants to merge 1 commit into
pr/v0.3/codex/wasmtime-maintenancefrom
codex/storage-abi-regressions
Draft

test(storage): cover final slot byte#18
MuncleUscles wants to merge 1 commit into
pr/v0.3/codex/wasmtime-maintenancefrom
codex/storage-abi-regressions

Conversation

@MuncleUscles

Copy link
Copy Markdown
Member

Summary

Adds two integration regressions at the final valid byte of a 2^32-byte storage slot:

  • a raw guest storage_read at offset 2^32 - 1 must succeed;
  • a deployed-contract write at the same offset must pass range validation and reach the independent locked-slot check (forbidden).

Both fixtures intentionally fail against the current ABI guard, which treats the valid end-exclusive range as an overflow. No production fix is included.

Why

The guard uses u32::checked_add, which rejects index = 2^32 - 1 with a one-byte buffer even though that accesses the slot's last valid byte.

Validation

  • Fixture Python sources compile successfully.
  • Full executor integration execution was not available in this isolated worktree; the expected outputs encode the intended current failure and fixed behavior.

Stacked on pr/v0.3/codex/wasmtime-maintenance.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d3513bcf-6850-4747-81ec-3a0a14714003

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant