Repository navigation
test(dblog): clear process-instance table in setUp for test isolation - #712
Open
C1-BA-B1-F3 wants to merge 1 commit into
Open
C1-BA-B1-F3 wants to merge 1 commit into
C1-BA-B1-F3 wants to merge 1 commit into
Conversation
test_db_content asserts the process-instance table is empty, but other tests may have left rows there, making the result order-dependent. Delete all rows in setUp so the test passes whether run alone or after other tests. Fixes geopython#679
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_db_contentasserts theprocess_instancetable has no rows withtime_end == None,status == None, orpercent_done < 100. When other tests run first they may leave rows in the table, making the assertions fail depending on test order.Fix
Delete all rows from
ProcessInstanceinsetUpso the test starts from a known empty state whether run alone or after other tests.Fixes #679