Repository navigation
fix(storage): use output identifier when reference filename is 'input' - #713
Open
C1-BA-B1-F3 wants to merge 2 commits into
Open
C1-BA-B1-F3 wants to merge 2 commits into
C1-BA-B1-F3 wants to merge 2 commits into
Conversation
test_db_content asserts the process-instance table is empty, but other tests may have left rows there, making the result order-dependent. Delete all rows in setUp so the test passes whether run alone or after other tests. Fixes geopython#679
When a ComplexOutput is returned as a reference and its file was inherited from a URL download, the generated URL always contains 'input.<ext>' (the default name for downloaded resources). Use the output identifier instead so the reference URL is meaningful to users. Fixes geopython#674
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a
ComplexOutputis returned as a reference and its file was inherited from a URL download, the generated URL always containsinput.<ext>(the default name for downloaded resources). This is misleading to users as it is actually the output file.Fix
In
_build_output_name, if the file name is the genericinputand the output has anidentifier, use the identifier as the file name prefix. This produces meaningful URLs likemy_result.csvinstead ofinput.csv.Test plan
file='/tmp/workdir/input.csv'andidentifier='my_result'→ generatesmy_result.csvFixes #674