Add review-plugin skill for reviewing plugin submission PRs - #346
Merged
Merged
Conversation
Adds a Claude Code skill (.claude/skills/review-plugin/SKILL.md) that guides reviewing a third-party plugin PR: an access check against maintainerCanModify (push fixes to the contributor's fork branch vs. comment-only), an isolated review/build on the contributor's own branch, and a final disposable-worktree merge into master-forge to catch and resolve pom.xml <modules>-list conflicts before they're real. Points at CONTRIBUTING.md/ARCHITECTURE.md/README.md/ AGENTS.md for the actual review checklist and branch model rather than duplicating them, and gates every push/comment/merge on explicit user approval. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.claude/skills/review-plugin/SKILL.md) that guides reviewing a third-party plugin PR: an access check (maintainerCanModify— push fixes to the contributor's fork branch, or comment-only if not enabled), an isolated review/build on the contributor's own branch, and a final disposable-worktree merge intomaster-forgeto catchpom.xml<modules>-list conflicts before they're real.CONTRIBUTING.md,ARCHITECTURE.md,README.md, andAGENTS.mdfor the actual review checklist and branch model rather than duplicating that content.master/master-forgedirectly, fix commits go to the contributor's fork branch, and every push/comment/merge is gated on explicit user approval.Test plan
master-forge, conflict resolution, build) — stopped short of any push/comment. Worktree and local branch/remote were cleaned up afterward.