Skip to content

fix: remove "healthy" from the default filter by default#60

Merged
rolznz merged 1 commit into
masterfrom
fix/discover-all
Jul 22, 2026
Merged

fix: remove "healthy" from the default filter by default#60
rolznz merged 1 commit into
masterfrom
fix/discover-all

Conversation

@rolznz

@rolznz rolznz commented Jul 22, 2026

Copy link
Copy Markdown
Member

sometimes healthy services are marked as degraded, and the check is not often updated.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the discover command so omitting --health no longer automatically filters results to healthy items.
    • Simplified the command-line option declaration for --protocol.

sometimes healthy services are marked as degraded, and the check is not often updated.
@rolznz
rolznz requested a review from reneaaron July 22, 2026 12:15
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3fb1b0a0-1142-476f-abb1-816d497ce129

📥 Commits

Reviewing files that changed from the base of the PR and between 42d902c and 0add424.

📒 Files selected for processing (1)
  • src/commands/discover.ts

📝 Walkthrough

Walkthrough

The discover CLI option declarations are updated. --protocol uses a single-line declaration, and omitting --health no longer implicitly selects healthy results.

Changes

Discover CLI options

Layer / File(s) Summary
Update discover option definitions
src/commands/discover.ts
Reformats the --protocol declaration and removes the "healthy" default from --health.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • getAlby/cli#13: Previously introduced the "healthy" default for the --health option.

Suggested reviewers: reneaaron

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: removing the default healthy filter from the discover command.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/discover-all

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rolznz
rolznz merged commit 11b2b79 into master Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant