feat(react-native): close remaining legacy parity gaps#1198
Merged
Conversation
…ait) Tightens the react-native commands to full parity for supported (Hermes/modern) RN configs: - xcode: Info.plist C preprocessing (`INFOPLIST_PREPROCESS=YES`) via `cc`, gated behind `--allow-xcode-infoplist-preprocessing` (matches the legacy flag). - xcode: discover the release via `xcodebuild -list -json` + `-showBuildSettings` when run outside an Xcode build phase (no `XCODE_VERSION_ACTUAL`). - gradle + xcode: `--wait`/`--wait-for` now actually block until the server finishes processing (state "ok"), with a `--wait-for` cap. Wired through a new `wait`/`maxWaitMs` option on `uploadSourcemaps` and a `waitForOk`/`deadlineMs` option on `pollAssembly` (default behavior unchanged for all other callers). RAM-bundle unpacking is intentionally left unsupported and documented as such — it is a pre-Hermes format React Native itself deprecated. New: shared `resolveUploadWait`, xcode-env `discoverInfoPlist` C-preprocess + xcodebuild paths. Tests: preprocessing, xcodebuild discovery, resolveUploadWait, and gradle --wait/--wait-for plumbing (8 new). Full suite 8411 passed.
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
Codecov Results 📊✅ Patch coverage is 80.73%. Project has 5307 uncovered lines. Files with missing lines (3)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 81.78% 81.88% +0.1%
==========================================
Files 423 423 —
Lines 29194 29282 +88
Branches 18980 19051 +71
==========================================
+ Hits 23874 23975 +101
- Misses 5320 5307 -13
- Partials 1968 1987 +19Generated by Codecov Action |
- gradle: correct stale --wait/--wait-for flag briefs (still claimed the flags were no-ops); they now match the real behavior + generated docs. - Validate --wait-for: reject NaN / non-positive seconds with a ValidationError before uploading (previously produced a confusing post-upload timeout). - xcode-env: resolve INFOPLIST_FILE with path.resolve so an absolute plist path is honored (join silently concatenated it). Tests: pollAssembly waitForOk matrix (default returns on "created"; waitForOk blocks through "created"→"ok"), --wait-for rejection cases. Full suite 8416.
Member
Author
Self-review (critical, via subagent)Verdict: no Critical/High regressions. Addressed the actionable findings in Verified no regression (the important ones):
Fixed:
Consciously kept (parity): with |
getBuildVars split on \n only, so a CRLF line ending would leave a trailing \r on the parsed value (e.g. INFOPLIST_FILE), producing an invalid path. Split on /\r?\n/ (matching Rust's .lines()). Test now emits CRLF output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens the
react-nativecommands to full functional parity with the legacy Rust CLI for all supported (Hermes / modern) React Native configurations — the last remaining behavioral gaps after the command port.What changed
react-native xcodeINFOPLIST_PREPROCESS=YES, run the plist throughcc -xc -P -E(withINFOPLIST_OTHER_PREPROCESSOR_FLAGS/INFOPLIST_PREPROCESSOR_DEFINITIONS), gated behind the legacy-matching--allow-xcode-infoplist-preprocessingflag.xcodebuilddiscovery outside Xcode — whenXCODE_VERSION_ACTUALisn't set, locate a single.xcodeproj, readxcodebuild -list -jsonfor targets/configurations, and pull the first target'sINFOPLIST_FILE/PROJECT_DIRfromxcodebuild -showBuildSettings(Release config, else Debug). Ports the legacyXcodeProjectInfopath.react-native gradle+xcode--wait/--wait-forare now real — they block until the server finishes processing the upload (state"ok"), with a--wait-for <secs>cap. Threaded through a new optionalwait/maxWaitMsonuploadSourcemapsand awaitForOk/deadlineMsonpollAssembly. Default behavior is unchanged for every other caller (returns onok/created), so the heavily-usedsourcemap uploadpath is untouched.Intentionally out of scope (documented): RAM-bundle unpacking. It's a pre-Hermes format React Native itself deprecated; the command emits a clear error and the docs say so.
Tests (+8, full suite 8411 passed)
xcode-env:ccpreprocessing (used when allowed, skipped when not),xcodebuilddiscovery (resolves via Release config; returns null with no.xcodeproj) —execFileSyncmocked so it runs on Linux CI.resolveUploadWait: no-flags /--wait/--wait-formapping.gradle:--wait/--wait-forthreadwait/maxWaitMsinto the upload.typecheck/lint/check:deps/check:fragmentsall pass. Docs fragment + generated skill updated.Closes the remaining react-native parity gaps; combined with the earlier ports, the TS CLI now matches the legacy CLI's functionality for all supported RN setups.