Skip to content

fix(changelog): Default workspace changelog to its directory - #888

Merged
BYK merged 2 commits into
masterfrom
fix/workspace-changelog-default-path
Oct 2, 2026
Merged

BYK merged 2 commits into
masterfrom
fix/workspace-changelog-default-path

Conversation

@BYK

@BYK BYK commented Oct 2, 2026

Copy link
Copy Markdown
Member

Summary

  • Default an unconfigured changelog path to <workspace>/CHANGELOG.md when the selected workspace is a real directory; keep explicit paths and root defaults for aliases and single-package repositories.
  • Use the same normalized path for release preparation and GitHub publication. Reject workspace directories that resolve outside the repository.
  • Document the default and test config resolution, GitHub target selection, and an isolated dry-run release with a distinct root changelog.

Validation

  • The directory-workspace regression failed against the old root default, passed with the fix, and failed again when the guard was removed.
  • pnpm run build, pnpm run typecheck, pnpm run lint, pnpm exec vitest run --printConsoleTrace (1,236 passed, 1 skipped), and pnpm run format:check passed. ESLint emitted seven pre-existing unused-binding warnings.

This lets getsentry/toolkit#1362 omit the explicit packages/cli/CHANGELOG.md override as requested.

Use the selected directory workspace for an unconfigured changelog path in prepare and GitHub publication. Preserve explicit paths and the root default for aliases and single-package repos.

Co-Authored-By: GPT-6 Sol (OpenAI) <agent@openai.com>
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-02 14:07 UTC

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c9e9a4. Configure here.

Comment thread src/targets/github.ts Outdated
Keep the existing publish guard for changelog-only configurations and cover that implicit-policy case with a regression.

Co-Authored-By: GPT-6 Sol (OpenAI) <agent@openai.com>
@BYK
BYK merged commit 0afdab4 into master Oct 2, 2026
23 checks passed
@BYK
BYK deleted the fix/workspace-changelog-default-path branch October 2, 2026 14:06

This branch was successfully deployed

1 active deployment
false — 8175a584 Deployed Oct 2, 2026 by BYK via Build #2957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant