feat(snapshots): Upload images under the snapshots objectstore usecase - #3408
Closed
NicoHinderling wants to merge 4 commits into
Closed
feat(snapshots): Upload images under the snapshots objectstore usecase#3408NicoHinderling wants to merge 4 commits into
NicoHinderling wants to merge 4 commits into
Conversation
Contributor
|
Request usecase=auto so the server picks the usecase from its own config, leaving future usecase changes entirely server-side.
NicoHinderling
marked this pull request as ready for review
September 11, 2026 21:02
NicoHinderling
requested review from
a team and
szokeasaurusrex
as code owners
September 11, 2026 21:02
Contributor
Author
|
Closing: the server side will move size-analysis content to a separate objectstore usecase instead, so snapshots keep using preprod and no CLI change is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot uploads now ask the upload-options endpoint for
?usecase=autoand build the objectstore session from theusecasethe server echoes back, instead of hardcodingpreprod. The server decides which usecase to mint the token for, so moving snapshot content between objectstore usecases in the future is a server-side config change with no CLI release. Servers that predate the field are handled by a serde default ofpreprod, so the CLI keeps working against older Sentry versions exactly as before.This pairs with getsentry/sentry#124194, which teaches the endpoint to honor
autoand echo its choice. The token's usecase claim must match the path the CLI builds, which is why the client uses the echoed value rather than assuming anything about the server's choice. Object keys are content hashes namespaced by usecase, so the first upload after a server-side switch re-sends every image once; later runs dedupe as usual.